bazel: bump rules_{oci,pkg} #60510
bazel: bump rules_{oci,pkg} #60510
Conversation
WORKSPACE
Outdated
| urls = [ | ||
| "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", | ||
| "https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip", | ||
| "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.46.0/rules_go-v0.46.0.zip", |
There was a problem hiding this comment.
Went through the changelog, LGTM
bazel-contrib/rules_go#3838 is interesting btw
| url = "https://github.com/bazel-contrib/rules_oci/releases/download/v1.4.3/rules_oci-v1.4.3.tar.gz", | ||
| sha256 = "cf6b8be82cde30daef18a09519d75269650317e40d917c8633cf8e3ab5645ea5", | ||
| strip_prefix = "rules_oci-1.7.2", | ||
| url = "https://github.com/bazel-contrib/rules_oci/releases/download/v1.7.2/rules_oci-v1.7.2.tar.gz", |
There was a problem hiding this comment.
Went through the changelog LGTM
| "https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.8.1/rules_pkg-0.8.1.tar.gz", | ||
| "https://github.com/bazelbuild/rules_pkg/releases/download/0.8.1/rules_pkg-0.8.1.tar.gz", | ||
| "https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.10.1/rules_pkg-0.10.1.tar.gz", | ||
| "https://github.com/bazelbuild/rules_pkg/releases/download/0.10.1/rules_pkg-0.10.1.tar.gz", |
There was a problem hiding this comment.
Went through the changelog, LGTM
cmd/server/macro.bzl
Outdated
| @@ -18,6 +18,7 @@ def container_dependencies(targets): | |||
| name = "tar_{}".format(name), | |||
| srcs = [target], | |||
| remap_paths = {"/{}".format(name): "/usr/local/bin/{}".format(name)}, | |||
| modes = {"/usr/local/bin/{}".format(name): "0555"}, | |||
There was a problem hiding this comment.
Currently broken due to bazelbuild/rules_pkg#822, hence tests are failing with files being 0o755 instead of 0o555
|
@Strum355 what's the status on that PR ? |
rules_go has been bumped separately already as part of moving to 1.22 |
Strum355
force-pushed
the
nsc/bazel-workspace-bump
branch
from
825e834
to
2fd50a1
Compare
Test plan
CI