Correctly mark failed runs

sourcemeta-research · Sep 26, 2024 · d1587f8 · d1587f8
1 parent f9c6036
commit d1587f8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -30,9 +30,9 @@ all: dist/report.csv ; cat $<
 define docker_run
   $(eval $@_TOOL = $(1))
   $(eval $@_INPUT = $(2))
-				$(shell docker run --rm -v $(CURDIR):/workspace jsonschema-benchmark/$($@_TOOL) $($@_INPUT) > $@)
+				-$(shell docker run --rm -v $(CURDIR):/workspace jsonschema-benchmark/$($@_TOOL) $($@_INPUT) > $@)
+				@if [ "$(.SHELLSTATUS)" -ne 0 ]; then echo "0"; fi > $@
 				@sed -i 's/$$/,$(.SHELLSTATUS)/' $@
-				@exit $(.SHELLSTATUS)
 endef
 
 # JSON Toolkit

diff --git a/implementations/ajv/main.mjs b/implementations/ajv/main.mjs
@@ -52,10 +52,9 @@ async function validateSchema(schemaPath, instancePath) {
   console.log(durationNs.toFixed(0));
 
   // Exit with non-zero status on validation failure
-  // XXX Skip since we allow ajv to fail
-  // if (failed) {
-  //   process.exit(1);
-  // }
+  if (failed) {
+    process.exit(1);
+  }
 }
 
 if (process.argv.length !== 4) {