Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly mark failed runs #45

Merged
merged 1 commit into from
Sep 26, 2024
+5 −6
Merged

Correctly mark failed runs #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ all: dist/report.csv ; cat $<
define docker_run
$(eval $@_TOOL = $(1))
$(eval $@_INPUT = $(2))
$(shell docker run --rm -v $(CURDIR):/workspace jsonschema-benchmark/$($@_TOOL) $($@_INPUT) > $@)
-$(shell docker run --rm -v $(CURDIR):/workspace jsonschema-benchmark/$($@_TOOL) $($@_INPUT) > $@)
@if [ ! -s $@ ]; then echo "0" > $@ ; fi
@sed -i 's/$$/,$(.SHELLSTATUS)/' $@
@exit $(.SHELLSTATUS)
endef

# JSON Toolkit
Expand Down
7 changes: 3 additions & 4 deletions implementations/ajv/main.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,9 @@ async function validateSchema(schemaPath, instancePath) {
console.log(durationNs.toFixed(0));

// Exit with non-zero status on validation failure
// XXX Skip since we allow ajv to fail
// if (failed) {
// process.exit(1);
// }
if (failed) {
process.exit(1);
}
}

if (process.argv.length !== 4) {
Expand Down
Loading