Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: Update dependencies (bulk dependabot PRs) 2024-10-28 #3188

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 28, 2024

✅ This PR was created by combining the following PRs:
#3187 bot: Bump vite from 5.4.9 to 5.4.10 in /playground
#3186 bot: Bump @types/react from 18.3.11 to 18.3.12 in /playground
#3185 bot: Bump eslint-plugin-react-refresh from 0.4.13 to 0.4.14 in /playground
#3182 bot: Bump github.com/ipfs/boxo from 0.24.0 to 0.24.2
#3181 bot: Bump github.com/zalando/go-keyring from 0.2.5 to 0.2.6
#3184 bot: Bump @typescript-eslint/parser from 8.10.0 to 8.11.0 in /playground
#3183 bot: Bump @typescript-eslint/eslint-plugin from 8.10.0 to 8.11.0 in /playground
#3180 bot: Bump github.com/lestrrat-go/jwx/v2 from 2.1.1 to 2.1.2

@fredcarle fredcarle changed the title bot: Update dependencies (bulk dependabot PRs) ${CURRENT_DATE} bot: Update dependencies (bulk dependabot PRs) 2024-10-28 Oct 28, 2024
@fredcarle fredcarle added the dependencies Related to dependencies label Oct 28, 2024
dependabot bot and others added 6 commits October 28, 2024 10:52
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.9 to 5.4.10.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.10/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.10/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.11 to 18.3.12.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint-plugin-react-refresh](https://github.com/ArnaudBarre/eslint-plugin-react-refresh) from 0.4.13 to 0.4.14.
- [Release notes](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/releases)
- [Changelog](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/main/CHANGELOG.md)
- [Commits](ArnaudBarre/eslint-plugin-react-refresh@v0.4.13...v0.4.14)

---
updated-dependencies:
- dependency-name: eslint-plugin-react-refresh
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/ipfs/boxo](https://github.com/ipfs/boxo) from 0.24.0 to 0.24.2.
- [Release notes](https://github.com/ipfs/boxo/releases)
- [Changelog](https://github.com/ipfs/boxo/blob/main/CHANGELOG.md)
- [Commits](ipfs/boxo@v0.24.0...v0.24.2)

---
updated-dependencies:
- dependency-name: github.com/ipfs/boxo
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/zalando/go-keyring](https://github.com/zalando/go-keyring) from 0.2.5 to 0.2.6.
- [Release notes](https://github.com/zalando/go-keyring/releases)
- [Commits](zalando/go-keyring@v0.2.5...v0.2.6)

---
updated-dependencies:
- dependency-name: github.com/zalando/go-keyring
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@fredcarle fredcarle force-pushed the combined-bot-prs-branch-2024-10-28 branch from 3acca4a to 79934e4 Compare October 28, 2024 14:52
@fredcarle fredcarle requested a review from a team October 28, 2024 14:53
go.mod Show resolved Hide resolved
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.47%. Comparing base (fee0d7e) to head (3028cff).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3188      +/-   ##
===========================================
+ Coverage    77.38%   77.47%   +0.10%     
===========================================
  Files          357      357              
  Lines        34809    34809              
===========================================
+ Hits         26934    26968      +34     
+ Misses        6256     6231      -25     
+ Partials      1619     1610       -9     
Flag Coverage Δ
all-tests 77.47% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee0d7e...3028cff. Read the comment docs.

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be worth quickly checking that the playground still works given the line-loss count in package-lock.json

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, spoke to soon - the vuln checker is complaining - please sort that out first, or let us know if it is something we can ignore.

@fredcarle fredcarle force-pushed the combined-bot-prs-branch-2024-10-28 branch from 5d2338b to 3028cff Compare October 28, 2024 16:06
@fredcarle
Copy link
Collaborator

My bad, spoke to soon - the vuln checker is complaining - please sort that out first, or let us know if it is something we can ignore.

Vulnerabilities were with go std lib dependencies. using go 1.22.7 ensures these are covered.

There is two approches to this:

// Option 1
go 1.22.0
toolchain go1.22.7

or

// Option 2
go 1.22.7

Option 1 might be preferred here since it aligns with how we want to support go versions. It states that we are supporting language features and tools of 1.22.0 but that Defra should be compiled with the 1.22.7 toolchain.

@AndrewSisley
Copy link
Contributor

Option 1 might be preferred here since it aligns with how we want to support go versions. It states that we are supporting language features and tools of 1.22.0 but that Defra should be compiled with the 1.22.7 toolchain.

Why would we not want the original, and not force users/compilers to pick a specific patch version?

go 1.22
toolchain go1.22.7

@fredcarle
Copy link
Collaborator

Why would we not want the original, and not force users/compilers to pick a specific patch version?

go 1.22
toolchain go1.22.7

go 1.22 no longer stays this way if you do go mod tidy. It did because our make tidy command specified go mod tidy -go=1.22

and not force users/compilers to pick a specific patch version

The toolchain is what forces compilers to use a specific patch. Using the toolchain directive for it will make it so go will fetch the required toolchain if it isn't available locally. Note that this is a minimum version. Users that have a newer go version locally will be using that newer version when compiling.

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, that is a little odd that Go works that way IMO, but I'm happy with the PR then :) Thanks for the explanation.

@fredcarle fredcarle merged commit 3a3baac into develop Oct 28, 2024
45 checks passed
@fredcarle fredcarle deleted the combined-bot-prs-branch-2024-10-28 branch October 28, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants