feat: Order alias target #3217
Merged
feat: Order alias target #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3217 +/- ##
===========================================
+ Coverage 77.41% 77.58% +0.16%
===========================================
Files 382 382
Lines 35178 35236 +58
===========================================
+ Hits 27233 27335 +102
+ Misses 6311 6279 -32
+ Partials 1634 1622 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fredcarle
reviewed
Nov 8, 2024
| }, | ||
| testUtils.Request{ | ||
| Request: `query { | ||
| Users(order: {_alias: {Age: ASC}}) { |
There was a problem hiding this comment.
thought: It would be nice to see a test with a compound order query that includes an alias.
fredcarle
approved these changes
Nov 8, 2024
islamaliev
pushed a commit
to islamaliev/defradb
that referenced
this pull request
Nov 13, 2024
## Relevant issue(s) Resolves sourcenetwork#3196 ## Description This PR adds alias targeting to query orderings. **Aggregate targets are not included in this PR as they require more changes.** ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Added integration tests. Specify the platform(s) on which this was tested: - MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #3196
Description
This PR adds alias targeting to query orderings.
Aggregate targets are not included in this PR as they require more changes.
Tasks
How has this been tested?
Added integration tests.
Specify the platform(s) on which this was tested: