Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add 'Ask Sourcery' keybinding #186

Merged
merged 1 commit into from
Jul 14, 2023
Merged

feat: Add 'Ask Sourcery' keybinding #186

merged 1 commit into from
Jul 14, 2023

Conversation

brendanator
Copy link
Contributor

@brendanator brendanator commented Jul 7, 2023 •
edited
Loading

Resolves SOU-1487

@brendanator brendanator requested review from bm424 and removed request for Hellebore July 7, 2023 12:38
bm424
bm424 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@bm424 bm424 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, this is quite a nice interaction. The initial message is showing at the moment but that should be fixed by sourcery-ai/core#2820 (unrelated tests failing at the moment).

Hellebore
Hellebore approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@Hellebore Hellebore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on mac - will test on windows when I can

@brendanator brendanator merged commit f5e2ae0 into main Jul 14, 2023
1 check passed
@brendanator brendanator deleted the brendan/keybindings branch July 14, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bm424 bm424 bm424 approved these changes

@Hellebore Hellebore Hellebore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendanator @Hellebore @bm424