Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add config and command to toggle off code lens #188

Merged
merged 2 commits into from
Jul 10, 2023
Merged

feat: add config and command to toggle off code lens #188

merged 2 commits into from
Jul 10, 2023

Conversation

Hellebore
Copy link
Contributor

@Hellebore Hellebore commented Jul 10, 2023 •
edited
Loading

Review with https://github.com/sourcery-ai/core/pull/2831

Checklist

  • If package.json or yarn.lock have changed, then test the VSIX built by yarn run vsce package works from a direct install

brendanator
brendanator approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@brendanator brendanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be a configuration option that appears in the settings like these options and gets written into the user config file
image

Maybe that's a follow up change?

package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Hellebore Hellebore merged commit 60c4450 into main Jul 10, 2023
1 check passed
@Hellebore Hellebore deleted the nick/sou-1542-add-vs-code-setting-to-disableenable-sourcery-code-lenses branch July 10, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanator brendanator brendanator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hellebore @brendanator