Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dont publish to ovsx #248

Merged
merged 1 commit into from
Jul 8, 2024
Merged

ci: dont publish to ovsx #248

merged 1 commit into from
Jul 8, 2024

Conversation

Hellebore
Copy link
Contributor

@Hellebore Hellebore commented Jul 8, 2024

Checklist

  • If package.json or yarn.lock have changed, then test the VSIX built by yarn run vsce package works from a direct install

Summary by Sourcery

This pull request updates the CI workflow by removing the step that publishes the package to the Open VSX Registry, simplifying the publishing process.

  • CI:
    • Removed the step to publish to Open VSX Registry from the GitHub Actions workflow.

Copy link
Contributor

sourcery-ai bot commented Jul 8, 2024

Reviewer's Guide by Sourcery

This pull request modifies the CI workflow by removing the step that publishes the VSIX package to the Open VSX registry. The change is implemented by deleting the 'yarn run ovsx publish' command from the '.github/workflows/publish.yml' file.

File-Level Changes

Files Changes
.github/workflows/publish.yml Removed the step to publish the VSIX package to the Open VSX registry in the GitHub Actions workflow.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hellebore - I've reviewed your changes and they look great!

Overall Comments:

  • Could you please provide some context on why the publication to Open VSX is being removed? Understanding the reasoning behind this change would be helpful for reviewers and future maintainers.
Here's what I looked at during the review
  • 🟢 Functionality: all looks good
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

LangSmith trace

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Hellebore Hellebore merged commit a081d9c into main Jul 8, 2024
1 check passed
@Hellebore Hellebore deleted the nick/feat/remove-ovsx branch July 8, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant