Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Make sure the plugin works with .aab builds #12

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nemanjar7
Copy link
Contributor

This is just a draft, as you can see, bundletool is required. It can be downloaded either manually from: https://developer.android.com/tools/bundletool or we can use homebrew as well: https://formulae.brew.sh/formula/bundletool. But now, if we are working on changing ansible playbooks it makes no sense downloading it from here, maybe just checking if it's there?
After we get that done it should be as straightforward as running: bundletool build-apks --bundle=aab_path.aab --output=release.apks

What are your thoughts on this approach?

@nemanjar7
Copy link
Contributor Author

We first merge this however: #11

@iBotPeaches
Copy link
Member

I like this approach, because I don't see any other option :)

  • I thought if you triggered a universal apk - you got the apk - so can you explain the unzip part?
  • lets see if bundletool is provided in sdk tools so we don't need to track on its own in brew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants