Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addPath method so it will also work on newarch interop #86

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ian-wd
Copy link

@ian-wd ian-wd commented Dec 10, 2024

  • on newarch interop addPath doesn't behave the same and it will only draw the first point and skip the rest of the points
  • the same code works if I disable newarch
  • unsure how will this impact the memory since current solution will now draw the paths right after building the points w/c actually fixed the issue

Copy link
Member

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran some tests and I believe this is fine. I like how it seems to batch the points to draw. It probably makes sense also to remove the canvas from the autoreleasepool as we aren't going to offload our literal canvas.

@ian-wd ian-wd marked this pull request as ready for review December 18, 2024 07:13
@iBotPeaches iBotPeaches merged commit 4e60f12 into master Dec 18, 2024
1 check passed
@iBotPeaches iBotPeaches deleted the addpath-interop-fix branch December 18, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants