Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singlesketch command #459

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Add singlesketch command #459

merged 7 commits into from
Oct 1, 2024

Conversation

mr-eyes
Copy link
Member

@mr-eyes mr-eyes commented Sep 30, 2024

This PR adds the singlesketch command to directly sketch a FASTA or stdin to resemble the regular sourmash sketch command.

@mr-eyes mr-eyes changed the title [WIP] Add singlesketch command Add singlesketch command Sep 30, 2024
@mr-eyes
Copy link
Member Author

mr-eyes commented Sep 30, 2024

Ready for review @ctb @bluegenes

Copy link
Collaborator

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work!

@mr-eyes
Copy link
Member Author

mr-eyes commented Oct 1, 2024

@ctb Thank you!! Ready to merge whenever:)

@ctb ctb merged commit 6bce2f4 into main Oct 1, 2024
1 check passed
@ctb ctb deleted the mo/sketch branch October 1, 2024 00:15
@bluegenes
Copy link
Contributor

wait! no, moltype needs to be fixed: the moltype that is needed at the beginning of sketching is actually the input moltype, not the sketch moltype -- i.e. is the FASTA file DNA or protein? I think an --input-moltype param might be needed.

@ctb @mr-eyes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants