MRG: update to code for forthcoming sourmash release #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizirber
reviewed
Oct 12, 2024
src/utils.rs
Outdated
Comment on lines
479
to
482
| if let Some(against_mh) = against_sig.minhash() { | ||
| // downsample against_mh, but keep original md5sum | ||
| let against_mh_ds = against_mh.downsample_scaled(query.scaled()).unwrap(); | ||
| let against_mh_ds = against_mh | ||
| .clone() |
There was a problem hiding this comment.
would an .into_minhash() in core that consumes the signature help here? would avoid the need for .clone(), which can be substantial for big sketches
There was a problem hiding this comment.
I'll make a PR against sourmash-bio/sourmash#3342
There was a problem hiding this comment.
There was a problem hiding this comment.
thanks! here's what I did; eliminated two (!!) clones,
There was a problem hiding this comment.
(comments obv welcome ;))
ctb
changed the title
|
Ready for review! Please let me manage merging tho 😭 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a standing PR to update to the forthcoming sourmash release, probably 0.16.0, which will hopefully include:
HashFunctionssourmash#3344 (not projected to cause any problems ;)KmerMinHash; fixRevIndex::gatherbug aroundscaled. sourmash#3342 (will need changes here ;))Fixes #468
TODO:
KmerMinHash; fixRevIndex::gatherbug aroundscaled. sourmash#3342 and this PR. (It probably won't be, but we could use a test anyway!)KmerMinHash; fixRevIndex::gatherbug aroundscaled. sourmash#3342