Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to set aclfile #485

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

simonasr
Copy link
Contributor

@simonasr simonasr commented Nov 10, 2023

Description

Adding aclfile option to Redis configuration file.

Issues Resolved

Enables configuring external ACL file for Redis v6+

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@simonasr simonasr requested a review from a team as a code owner November 10, 2023 15:52
@xorima
Copy link
Contributor

xorima commented Nov 11, 2023

Hey @simonasr

Thanks for this. Can you drop an update to the change log under the ## Unreleased section then I can get this shipped asap

@simonasr
Copy link
Contributor Author

Hey @simonasr

Thanks for this. Can you drop an update to the change log under the ## Unreleased section then I can get this shipped asap

Thanks @xorima! Changelog updated.

@xorima xorima added the Release: Minor Release to Chef Supermarket as a minor release when merged label Nov 11, 2023
@xorima xorima merged commit c51c6ed into sous-chefs:main Nov 11, 2023
25 of 41 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 6.6.0

@damacus
Copy link
Member

damacus commented Nov 11, 2023

@simonasr do you want to take point on removing some of the older configuration options for redis?

Looks like we really only want to be supporting 6+ at a minimum

https://endoflife.date/redis

@simonasr simonasr deleted the feature/aclfile_option branch November 11, 2023 18:44
@simonasr
Copy link
Contributor Author

@simonasr do you want to take point on removing some of the older configuration options for redis?

Looks like we really only want to be supporting 6+ at a minimum

https://endoflife.date/redis

Hi @damacus

Sure, I'd be happy to help with that in my free time. Just to be clear, are we talking about removing obsolete conditional statements from the configuration templates and related code if such, or is there more to it? As far as I know, Redis hasn't actually removed any configuration options, so I just want to understand the scope of what we're doing.

@damacus
Copy link
Member

damacus commented Nov 11, 2023

Yeah, pretty much want to make sure 6 and 7 work. It's easier if it's headed up by someone who still uses it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants