Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defaults for FreeBSD systems #185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

zi0r
Copy link
Contributor

@zi0r zi0r commented May 14, 2021

Description

Updates defaults to be compatible with FreeBSD systems

Issues Resolved

None

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@the-label-bot
Copy link

the-label-bot bot commented May 14, 2021

Kind Prediction: feature
Confidence: 0.999

Provide the bot with feedback using a 👍 or 👎!

@the-label-bot
Copy link

the-label-bot bot commented May 14, 2021

Size Prediction: small
Confidence: 0.999

Nice! This should be quick to review

Provide the bot with feedback using a 👍 or 👎!

@kitchen-porter
Copy link
Contributor

1 Warning
⚠️ This Pull Request is probably missing tests.

Generated by 🚫 Danger

@ramereth
Copy link
Contributor

This is going to need to wait until we get this cookbook updated for Chef 17 so the tests pass properly. We should be getting that done soon.

@zi0r
Copy link
Contributor Author

zi0r commented May 17, 2021

No rush. These are easy to set in the calling cookbook, so this is more of a "make this nicer" than a blocker for use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants