Remove recipes and attributes #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
damacus
commented
May 10, 2023
damacus
commented
- Remove recipes and attributes
- Remove duplicate _ConfigurationFile.ini.erb
- Remove specs for recipes
- Move the InSpec test to the correct directory
- Remove recipes and attributes - Remove duplicate _ConfigurationFile.ini.erb - Remove specs for recipes - Move the InSpec test to the correct directory
damacus
added
the
Release: Major
JHBoricua
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Minor typo that needs fixing in the helper library.
Also, on line 46 of the install resource file, the feature SNAC-SDK needs to be removed from the array if we are defaulting to SQL 2022 in the cookbook. Per Microsoft, that feature applies to SQL 2019 and earlier versions: https://learn.microsoft.com/en-us/sql/database-engine/install-windows/install-sql-server-from-the-command-prompt?view=sql-server-ver16#Feature
Otherwise the new default kitchen suite will fail during the install phase.
xorima
approved these changes
Sep 28, 2023
xorima
previously approved these changes
Sep 28, 2023
Co-authored-by: Jose A Hernandez <[email protected]>
|
Released as: 8.0.0 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.