Tracyboehrer/get value parity (microsoft#4639)

* DialogStateManager.getValue does not throw for missing Scope (DotNet parity) * Corrected DialogStateManager test --------- Co-authored-by: Tracy Boehrer <[email protected]>
southworks · Apr 2, 2024 · 7ceb965 · 7ceb965
1 parent 6782cdd
commit 7ceb965
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/libraries/botbuilder-dialogs/src/memory/dialogStateManager.ts b/libraries/botbuilder-dialogs/src/memory/dialogStateManager.ts
@@ -118,7 +118,8 @@ export class DialogStateManager {
         // Get memory scope to search over
         const scope = this.getMemoryScope(segments[0].toString());
         if (scope == undefined) {
-            throw new Error(`DialogStateManager.getValue: a scope of '${segments[0]}' wasn't found.`);
+            console.warn(`DialogStateManager.getValue: a scope of '${segments[0]}' wasn't found for '${pathExpression}'.`);
+            return returnDefault();
         }
 
         // Search over path

diff --git a/libraries/botbuilder-dialogs/tests/memory/dialogStateManager.test.js b/libraries/botbuilder-dialogs/tests/memory/dialogStateManager.test.js
@@ -229,7 +229,7 @@ describe('Dialog State Manager', function () {
     });
 
     it('raise an error if getValue() called with an invalid scope.', function () {
-        assert.throws(() => this.dc.state.getValue('foo.bar'));
+        assert.strictEqual(this.dc.state.getValue('foo.bar'), undefined);
     });
 
     it('raise an error if setValue() called with missing path.', function () {