keep previous constructor with new structure

southworks · Dec 7, 2023 · 8803011 · 8803011
1 parent 3c7ed5e
commit 8803011
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/libraries/botframework-connector/src/auth/certificateServiceClientCredentialsFactory.ts b/libraries/botframework-connector/src/auth/certificateServiceClientCredentialsFactory.ts
@@ -71,16 +71,12 @@ export class CertificateServiceClientCredentialsFactory extends ServiceClientCre
             'CertificateServiceClientCredentialsFactory.constructor(): missing certificatePrivateKey.'
         );
 
-        if (certificateThumbprintOrx5c.includes('-----BEGIN CERTIFICATE-----')) {
+        if (certificateThumbprintOrx5c?.includes('-----BEGIN CERTIFICATE-----')) {
             this.x5c = certificateThumbprintOrx5c;
-            ok(
-                certificateThumbprintOrx5c.trim(),
-                'CertificateServiceClientCredentialsFactory.constructor(): missing x5c.'
-            );
         } else {
             ok(
                 certificateThumbprintOrx5c.trim(),
-                'CertificateServiceClientCredentialsFactory.constructor(): missing certificateThumbprint.'
+                'CertificateServiceClientCredentialsFactory.constructor(): missing certificateThumbprint or x5c value.'
             );
             this.certificateThumbprint = certificateThumbprintOrx5c;
             this.x5c = x5c;