Skip to content

Commit

Permalink
fix lint issues with vendors
Browse files Browse the repository at this point in the history
  • Loading branch information
JhontSouth committed Dec 10, 2024
1 parent b207e73 commit d542d8a
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -316,3 +316,6 @@ coverage
# typescript assets
*.tsbuildinfo
*.js.map

# tsup vendors folders
libraries/**/vendors
1 change: 1 addition & 0 deletions eslint.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ module.exports = [
'**/*.lu',
'**/*.dialog',
'**/*.js.map',
'**/vendors'
],
},

Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-azure-blobs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"clean": "rimraf _ts3.4 lib vendors tsconfig.tsbuildinfo",
"depcheck": "depcheck --config ../../.depcheckrc",
"lint": "eslint . --config ../../eslint.config.cjs",
"prebuild": "tsup ../../node_modules/p-map/*.js --format cjs --dts --out-dir vendors/p-map --clean --sourcemap",
"prebuild": "tsup ./node_modules/p-map/*.js --format cjs --dts --out-dir vendors/p-map --clean --sourcemap",
"postbuild": "downlevel-dts lib _ts3.4/lib --checksum",
"test": "yarn build && nyc mocha --check-leaks tests",
"test:compat": "api-extractor run --verbose"
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-azure/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"clean": "rimraf _ts3.4 lib vendors tsconfig.tsbuildinfo",
"depcheck": "depcheck --config ../../.depcheckrc",
"lint": "eslint .",
"prebuild": "tsup ../../node_modules/p-map/*.js --format cjs --dts --out-dir vendors/p-map --clean --sourcemap",
"prebuild": "tsup ./node_modules/p-map/*.js --format cjs --dts --out-dir vendors/p-map --clean --sourcemap",
"postbuild": "downlevel-dts lib _ts3.4/lib --checksum",
"test": "yarn build && nyc mocha tests/",
"test:compat": "api-extractor run --verbose"
Expand Down
8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,15 @@
],
"nohoist": [
"**/@types/selenium-webdriver",
"botbuilder/filenamify"
"botbuilder/filenamify",
"botbuilder-azure/p-map",
"botbuilder-azure-blobs/p-map"
],
"nohoistComments": {
"**/@types/selenium-webdriver": "This package is excluded from the root @types folder as it requires ES2015+, whereas some BotBuilder libraries support ES5+.",
"botbuilder/filenamify": "This package is excluded because it's compiled as CJS by tsup as it's ESM-only."
"botbuilder/filenamify": "This package is excluded because it's compiled as CJS by tsup as it's ESM-only.",
"botbuilder-azure/p-map": "This package is excluded because it's compiled as CJS by tsup as it's ESM-only.",
"botbuilder-azure-blobs/p-map": "This package is excluded because it's compiled as CJS by tsup as it's ESM-only."
}
},
"scripts": {
Expand Down

0 comments on commit d542d8a

Please sign in to comment.