fix: [#4470] Migrate off @azure/ms-rest-js #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhontSouth
changed the title
ceciliaavila
requested changes
Nov 1, 2023
…to southworks/delete/ms-rest-js-botbuilder
Pull Request Test Coverage Report for Build 7088992860
💛 - Coveralls |
ceciliaavila
requested changes
Nov 3, 2023
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| import * as Mappers from './models/mappers'; | |||
| import * as Models from './models'; | |||
| import * as msRest from '@azure/ms-rest-js'; | |||
| import { ServiceClientCredentials } from "@azure/core-http" | |||
Comment on lines
+726
to
+730
| name: "Sequence", | ||
| element: { | ||
| type: { | ||
| name: "Composite", | ||
| className: "ChannelAccount" |
There was a problem hiding this comment.
What happened with the indentation? Is the new one correct?
| @@ -3,7 +3,7 @@ | |||
| * Licensed under the MIT License. | |||
| */ | |||
|
|
|||
| import * as msRest from '@azure/ms-rest-js'; | |||
| import { ServiceCallback, RequestOptionsBase, Serializer, OperationSpec } from "@azure/core-http"; | |||
libraries/tests.uischema
Outdated
Comment on lines
11
to
12
| "schema", | ||
| "dialogs" |
There was a problem hiding this comment.
to avoid errors with test:schema
sw-joelmut
requested changes
Dec 1, 2023
sw-joelmut
approved these changes
Dec 4, 2023
ceciliaavila
approved these changes
Dec 4, 2023
|
Promoted /4578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR replaces the uses of @azure/ms-rest-js in the following botbuilder-js libraries.
Specific Changes
Testing
The following image shows some samples working after the update.
