Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4470] Migrate off @azure/ms-rest-js tools #377

Closed
wants to merge 3 commits into from

Conversation

JhontSouth
Copy link

@JhontSouth JhontSouth commented Nov 2, 2023

#minor

Description

This PR replaces the uses of @azure/ms-rest-js in the following botbuilder-js libraries.

  • botbuilder
  • botbuilder-ai
  • botframework-connector
  • tool

Specific Changes

  • Replaced the @azure/ms-rest-js imports with @azure/core-http.
  • Added @azure/core-http to libraries package.json.
  • Added @azure/core-util version 1.5.0 to resolutions.
  • Updated unit tests to work with core-http RestError.

Testing

The following image shows some samples working after the update.
image
image

@JhontSouth JhontSouth changed the base branch from southworks/delete/ms-rest-js-botbuilder to main November 2, 2023 15:10
@JhontSouth JhontSouth changed the base branch from main to southworks/delete/ms-rest-js-botbuilder November 2, 2023 15:25
@JhontSouth JhontSouth changed the base branch from southworks/delete/ms-rest-js-botbuilder to main November 2, 2023 15:26
@JhontSouth JhontSouth closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant