Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4470] Migrate off @azure/ms-rest-js tools #381

Closed
wants to merge 6 commits into from

Conversation

JhontSouth
Copy link

#minor

Description

This PR replaces the uses of @azure/ms-rest-js in the following botbuilder-js libraries.

  • botbuilder
  • botbuilder-ai
  • botframework-connector
  • tools

Specific Changes

  • Replaced the @azure/ms-rest-js imports with @azure/core-http.
  • Added @azure/core-http to libraries package.json.
  • Added @azure/core-util version 1.5.0 to resolutions.
  • Updated unit tests to work with core-http RestError.

Testing

The following image shows some samples working after the update.
image
image

@coveralls
Copy link

coveralls commented Nov 2, 2023

Pull Request Test Coverage Report for Build 7088187965

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.645%

Totals Coverage Status
Change from base Build 7049677954: 0.0%
Covered Lines: 20346
Relevant Lines: 22770

💛 - Coveralls

package.json Outdated Show resolved Hide resolved
@JhontSouth
Copy link
Author

Promoted /4576

@JhontSouth JhontSouth closed this Dec 4, 2023
@JhontSouth JhontSouth deleted the southworks/delete/ms-rest-js-tools branch December 4, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants