Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update axios and fix issue in botframework-connector #392

Closed
wants to merge 2 commits into from

Conversation

JhontSouth
Copy link

@JhontSouth JhontSouth commented Dec 21, 2023

#minor

Description

This PR updates the axios package and replaces it with fetch in botframework-connector due to a breaking change in version 1.x.x of axios.

Specific Changes

  • Updated axios version to ^1.6.0 in botbuilder and botbuilder-core.
  • Replaced axios with fetch in the botFrameworkClientImpl class.

Testing

The following image shows a bot working using CloudAdapter with the botframework-connector fix.
image

@coveralls
Copy link

coveralls commented Dec 21, 2023

Pull Request Test Coverage Report for Build 7300677763

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.632%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-connector/src/auth/botFrameworkClientImpl.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 7167998757: 0.4%
Covered Lines: 20373
Relevant Lines: 22802

💛 - Coveralls

@JhontSouth
Copy link
Author

Promoted /4591

@JhontSouth JhontSouth closed this Dec 22, 2023
@JhontSouth JhontSouth deleted the southworks/fix/update-axios branch December 22, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants