New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add HTTP method in fetch request #393

Closed

JhontSouth wants to merge 1 commit into main from southworks/fix/add-fetch-http-method

JhontSouth commented Dec 22, 2023

#minor

Description

This PR includes the HTTP method post to the fetch request.

Specific Changes

Added post method to the fetch request in botFrameworkClientImpl.
Imported fetch from cross-fetch.
Removed the body parse.

Testing

The following image shows a skill bot working using CloudAdapter with the botframework-connector fix.


          include http method in fetch request

9ac6aed

JhontSouth requested a review from ceciliaavila

December 22, 2023 14:55

ceciliaavila approved these changes

View reviewed changes

coveralls commented Dec 22, 2023 •

edited

Loading

Pull Request Test Coverage Report for Build 7301155738

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.541%

Totals
Change from base Build 7301030409:	0.0%
Covered Lines:	20416
Relevant Lines:	22872

💛 - Coveralls

Author

JhontSouth commented Dec 22, 2023

Promoted /4593

JhontSouth closed this

JhontSouth deleted the southworks/fix/add-fetch-http-method branch

December 22, 2023 15:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet