refactor: Improve calculateChangeHash to avoid circular reference errors #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR updates the internal BotState cache hash functionality to prevent
JSON.stringify
from throwing circular reference errors, and generates from the resulted string a hash using thenode:crypto
library.Specific Changes
calculateChangeHash
with an improved functionality.JSON.stringify
from throwing circular reference errors.node:crypto
library to generate a hash value that is easier to use for debugging and storing.Testing
The following images show how this new functionality detects and replaces circular references, and the generated hash string.