Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use npm to run postinstall scripts #405

Closed
wants to merge 1 commit into from
Closed

fix: Use npm to run postinstall scripts #405

wants to merge 1 commit into from

Conversation

JhontSouth
Copy link

#minor

Description

This PR replaces yarn with npm to execute the postinstall scripts.

Specific Changes

  • Replaced yarn command with npm run command in botbuilder-dialogs and botbuilder-dialogs-adaptive

Testing

The following image shows the postinstall script working with npm run.
image

@coveralls
Copy link

coveralls commented Jan 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7698212456

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.48%
Totals Coverage Status
Change from base Build 7655771417: 0.0%
Covered Lines: 20414
Relevant Lines: 22880
💛 - Coveralls

@ceciliaavila
Copy link

promoted

@ceciliaavila ceciliaavila deleted the southworks/fix/use-npm-postintall-scripts branch February 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceciliaavila ceciliaavila ceciliaavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JhontSouth @coveralls @ceciliaavila