Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4584] ChannelAccount cannot accept extensible properties #407

Closed

Conversation

JhontSouth
Copy link

#minor

Description

This PR includes the Properties property to the ChannelAccount interface to allow using optional properties.

Specific Changes

  • Added Properties property to the ChannelAccount interface.
  • Added properties serialization in CompositeMapper.

Testing

The following image shows the object Properties retrieved in the request body of the bot.
image

@coveralls
Copy link

coveralls commented Feb 2, 2024

Pull Request Test Coverage Report for Build 7760617838

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.48%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 85.34%
Totals Coverage Status
Change from base Build 7655771417: 0.0%
Covered Lines: 20414
Relevant Lines: 22880

💛 - Coveralls

@JhontSouth
Copy link
Author

Promoted /4618

@JhontSouth JhontSouth closed this Feb 13, 2024
@JhontSouth JhontSouth deleted the southworks/fix/optional-properties-channelaccount branch February 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants