Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [#4636] Add more information to Tenant parameters #416

Closed
wants to merge 1 commit into from

Conversation

sw-joelmut
Copy link

Fixes # 4636
#minor

Description

This PR adds more information to optional Tenant parameters used in authentication classes. Explaining when it's optional or required, and the default when no value is provided.

Specific Changes

  • Add Tenant comment to authentication (AppCredentials, CertificateAppCredentials, MicrosoftAppCredentials, and auth factories) classes.
  • The new comment contains information when required, optional, and the default value. Additionally, a link to the supported Azure app types.

Testing

The following image shows how the new comment looks.
image

@coveralls
Copy link

coveralls commented Apr 19, 2024

Pull Request Test Coverage Report for Build 8754752970

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.431%

Totals Coverage Status
Change from base Build 8754626788: 0.0%
Covered Lines: 20426
Relevant Lines: 22901

💛 - Coveralls

@sw-joelmut sw-joelmut changed the title [#4636] Add more information to Tenant parameters chore: [#4636] Add more information to Tenant parameters Apr 19, 2024
@sw-joelmut
Copy link
Author

/promoted 4649

@sw-joelmut sw-joelmut closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants