Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4483] Switching npm dependency bcrypt to bcryptjs #422

Closed
wants to merge 2 commits into from

Conversation

JhontSouth
Copy link

@JhontSouth JhontSouth commented May 22, 2024

Fixes # 4483
#minor

Description

This PR changes the use of bcrypt for bcryptjs to improve the portability of botbuilder-js.

Specific Changes

  • Replaced bcrypt ^5.0.1 by bcryptjs ^2.4.3.

Testing

The following image shows the CosmosDbKeyEscape unit tests working with the hashSync method from bcryptjs.
image

@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 9194607216

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.431%

Totals Coverage Status
Change from base Build 9177080497: 0.0%
Covered Lines: 20426
Relevant Lines: 22901

💛 - Coveralls

@JhontSouth
Copy link
Author

Promoted /4669

@JhontSouth JhontSouth closed this May 23, 2024
@JhontSouth JhontSouth deleted the southworks/fix/bcrypt-portability branch May 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants