Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CodeQL SM04509 issue #424

Closed
wants to merge 2 commits into from

Conversation

andres-robinet-sw
Copy link

@andres-robinet-sw andres-robinet-sw commented May 23, 2024

#minor

Description

This PR removes eval() from the botbuilder-lg package.
There is no need for side-effects at execution time for the nullSubstitution lambda function.
Additionally, the related CodeQL and ESLint suppressions have been removed, as there is no use for them anymore.
image

Specific Changes

  • Removed unnecesary eval() code.
  • Removed ESLint suppression for security/detect-eval-with-expression.
  • Removed ESLint suppression for @typescript-eslint/no-unused-vars.
  • Removed CodeQL suppression for SM04509.

Testing

The following image shows EvaluationOptions tests passing (along with all other tests).
image

@coveralls
Copy link

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 9214956234

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.431%

Totals Coverage Status
Change from base Build 9177080497: 0.0%
Covered Lines: 20425
Relevant Lines: 22900

💛 - Coveralls

@andres-robinet-sw andres-robinet-sw marked this pull request as ready for review May 23, 2024 21:24
@andres-robinet-sw
Copy link
Author

/promoted 4671

@andres-robinet-sw andres-robinet-sw deleted the southworks/fix/codeql-SM04509-issue branch June 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants