Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-dialogs-adaptive #492

Closed

Conversation

sw-joelmut
Copy link

Addresses # 4684
#minor

Description

This PR fixes all the new ESLint errors and warnings that appeared after the ESLint packages' upgrade in the botbuilder-dialogs-adaptive project.

Specific Changes

  • Removed 'only-warn' plugin from 'botbuilder-dialogs-adaptive/eslint.config.cjs' and its dependency.
  • All updated TS and JS files were due to prettier, mocha and jsdoc new rules.

Testing

The following image shows that there are no more ESLint issues.
image

@sw-joelmut sw-joelmut changed the base branch from southworks/update/eslint-packages to main November 14, 2024 18:15
@sw-joelmut sw-joelmut force-pushed the southworks/fix/eslint-botbuilder-dialogs-adaptive branch from 1da8c4d to e25a5f2 Compare November 14, 2024 18:35
Copy link

Pull Request Test Coverage Report for Build 11843384947

Details

  • 21 of 22 (95.45%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 84.355%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/adaptiveDialog.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 11691458662: -0.3%
Covered Lines: 20433
Relevant Lines: 23064

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 12316126392

Details

  • 21 of 22 (95.45%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.625%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/adaptiveDialog.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 12261207668: 0.0%
Covered Lines: 20513
Relevant Lines: 23091

💛 - Coveralls

@sw-joelmut
Copy link
Author

/promoted 4826

@sw-joelmut sw-joelmut closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants