Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] ESLint issues in botbuilder-ai-luis #495

Closed
wants to merge 2 commits into from

Conversation

sw-joelmut
Copy link

Addresses # 4684
#minor

Description

This PR removes the unnecessary eslint.config file to reference the root one directly in the botbuilder-ai-luis project. No ESLint warnings or errors found.

Specific Changes

  • Removed 'only-warn' plugin from 'botbuilder-ai-luis'.

Testing

The following image shows that there are no more ESLint issues.
image

@sw-joelmut sw-joelmut changed the base branch from southworks/update/eslint-packages to main November 14, 2024 18:15
@sw-joelmut sw-joelmut force-pushed the southworks/fix/eslint-botbuilder-ai-luis branch from 2590b95 to 9bd3c7e Compare November 14, 2024 18:33
@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 12316442214

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.625%

Totals Coverage Status
Change from base Build 12261207668: 0.0%
Covered Lines: 20513
Relevant Lines: 23091

💛 - Coveralls

@sw-joelmut
Copy link
Author

/promoted 4824

@sw-joelmut sw-joelmut closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants