Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESLint issues in botbuilder #501

Closed
wants to merge 9 commits into from

Conversation

JhontSouth
Copy link

@JhontSouth JhontSouth commented Oct 24, 2024

Addresses # 4684
#minor

Description

This PR fixes the new ESLint issues after upgrading the ESLint packages in the botbuilder library.

Specific Changes

  • Removed botbuilder eslint.config.cjs file.
  • Applied the fixes needed for all the issues detected by ESLint.
  • Removed duplicated unit test in teamsActivityHandler.test.

Testing

The following image shows the issues fixed in the library.
image

@JhontSouth JhontSouth changed the base branch from main to southworks/update/eslint-packages October 24, 2024 16:18
package.json Outdated Show resolved Hide resolved
libraries/botbuilder/package.json Outdated Show resolved Hide resolved
libraries/botbuilder/src/cloudAdapter.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/cloudSkillHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/skillHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/teamsActivityHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/cloudSkillHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/cloudSkillHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/skillHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/skillHandler.ts Outdated Show resolved Hide resolved
@JhontSouth JhontSouth changed the title fix: ESLint issues in bobuilder fix: ESLint issues in botbuilder Oct 28, 2024
libraries/botbuilder/src/skills/cloudSkillHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/cloudSkillHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/skillHandler.ts Outdated Show resolved Hide resolved
libraries/botbuilder/src/skills/skillHandler.ts Outdated Show resolved Hide resolved
@JhontSouth JhontSouth changed the base branch from southworks/update/eslint-packages to main November 13, 2024 18:43
@JhontSouth JhontSouth force-pushed the southworks/fix/eslint-issues-botbuilder branch from e4b3220 to cbe7fb3 Compare November 13, 2024 18:43
@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 12434846709

Details

  • 18 of 23 (78.26%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.622%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/botFrameworkAdapter.ts 7 8 87.5%
libraries/botbuilder/src/skills/cloudSkillHandler.ts 0 1 0.0%
libraries/botbuilder/src/skills/skillHttpClient.ts 0 1 0.0%
libraries/botbuilder/src/cloudAdapter.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 12261207668: -0.003%
Covered Lines: 20515
Relevant Lines: 23094

💛 - Coveralls

@JhontSouth
Copy link
Author

Promoted /4830

@JhontSouth JhontSouth closed this Dec 20, 2024
@JhontSouth JhontSouth deleted the southworks/fix/eslint-issues-botbuilder branch December 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants