forked from microsoft/botbuilder-js
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ESLint issues in botbuilder #501
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhontSouth
changed the base branch from
main
to
southworks/update/eslint-packages
October 24, 2024 16:18
sw-joelmut
reviewed
Oct 24, 2024
ceciliaavila
requested changes
Oct 24, 2024
sw-joelmut
approved these changes
Oct 28, 2024
ceciliaavila
requested changes
Oct 28, 2024
JhontSouth
changed the title
fix: ESLint issues in bobuilder
fix: ESLint issues in botbuilder
Oct 28, 2024
ceciliaavila
requested changes
Oct 29, 2024
ceciliaavila
approved these changes
Oct 29, 2024
…eslint-issues-botbuilder
JhontSouth
changed the base branch from
southworks/update/eslint-packages
to
main
November 13, 2024 18:43
JhontSouth
force-pushed
the
southworks/fix/eslint-issues-botbuilder
branch
from
November 13, 2024 18:43
e4b3220
to
cbe7fb3
Compare
Pull Request Test Coverage Report for Build 12434846709Details
💛 - Coveralls |
Promoted /4830 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses # 4684
#minor
Description
This PR fixes the new ESLint issues after upgrading the ESLint packages in the botbuilder library.
Specific Changes
Testing
The following image shows the issues fixed in the library.