Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESLint issues in adaptive-expressions #510

Closed

Conversation

JhontSouth
Copy link

Addresses # 4684
#minor

Description

This PR fixes all the new errors and warnings incoming in the latest version of ESLint packages in adaptive-expressions.

Specific Changes

  • Removed unnecessary skips of deprecated rules.
  • Formatted with required spaces and comment lines required by ESLint.
  • Added skips for some package imports with require.

Testing

The following image shows the lint command running without problems in adaptive-expressions.
image

@JhontSouth JhontSouth changed the title fix: Remove ESLint config file in adaptive-expressions fix: ESLint issues in adaptive-expressions Nov 14, 2024
@JhontSouth JhontSouth changed the base branch from southworks/update/eslint-packages to main November 14, 2024 16:07
@JhontSouth JhontSouth force-pushed the southworks/fix/eslint-issues-adaptive-expressions branch from b14f6f0 to 4a2a15d Compare November 14, 2024 16:07
@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 12435327687

Details

  • 109 of 120 (90.83%) changed or added relevant lines in 25 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 84.619%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 0 1 0.0%
libraries/adaptive-expressions/src/builtinFunctions/formatTicks.ts 15 17 88.24%
libraries/adaptive-expressions/src/builtinFunctions/string.ts 21 23 91.3%
libraries/adaptive-expressions/src/builtinFunctions/formatNumber.ts 16 19 84.21%
libraries/adaptive-expressions/src/triggerTrees/quantifier.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 12261207668: -0.006%
Covered Lines: 20512
Relevant Lines: 23092

💛 - Coveralls

@JhontSouth
Copy link
Author

Promoted /4833

@JhontSouth JhontSouth closed this Dec 20, 2024
@JhontSouth JhontSouth deleted the southworks/fix/eslint-issues-adaptive-expressions branch December 20, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants