Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESLint issues in botbuilder-repo-utils #519

Closed

Conversation

JhontSouth
Copy link

Addresses # 4684
#minor

Description

This PR fixes the new ESLint issues after upgrading the ESLint packages in the botbuilder-repo-utils library.

Specific Changes

  • Removed botbuilder-repo-utils eslint.config.cjs file.
  • Applied the needed fixes to all the issues detected by ESLint.

Testing

The following image shows the issues fixed in the library.
image

@JhontSouth JhontSouth force-pushed the southworks/fix/eslint-issues-botbuilder-repo-utils branch from fbbabb2 to f81a355 Compare November 14, 2024 16:38
@JhontSouth JhontSouth changed the base branch from southworks/update/eslint-packages to main November 14, 2024 16:38
@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12435968710

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.625%

Totals Coverage Status
Change from base Build 12261207668: 0.0%
Covered Lines: 20513
Relevant Lines: 23091

💛 - Coveralls

@JhontSouth
Copy link
Author

Promoted /4838

@JhontSouth JhontSouth closed this Dec 20, 2024
@JhontSouth JhontSouth deleted the southworks/fix/eslint-issues-botbuilder-repo-utils branch December 20, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants