Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#6861]TeamsSSOTokenExchangeMiddleware.DeduplicatedTokenExchangeIdAsync fails on BlobStorage ETag validation #525

Closed
wants to merge 1 commit into from

Conversation

ceciliaavila
Copy link

#minor

Description

This PR ports the changes from [BotBuilder-DotNet's PR#6867](https ://github.com/microsoft/botbuilder-dotnet/pull/ 6867) to handle eTag conflicts on concurrent calls to the BlobsStorage write method.

Specific Changes

  • Added a try-catch block to handle the 412 error code in the write method of BlobsStorage class.
  • Added a unit test to cover this scenario in blobsStorage.tests.js.

Testing

This image shows the new unit tests working.
image

@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 11955774357

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.689%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-azure-blobs/src/blobsStorage.ts 0 8 0.0%
Totals Coverage Status
Change from base Build 11691458662: -0.02%
Covered Lines: 20515
Relevant Lines: 23068

💛 - Coveralls

@ceciliaavila
Copy link
Author

/promoted 4800

@ceciliaavila ceciliaavila deleted the southworks/update/manage-error-412 branch November 22, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants