New Always True policy should not cause errors (#1012)

sovity · Aug 5, 2024 · 4f0ae71 · 4f0ae71
1 parent 8028c11
commit 4f0ae71
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,8 @@ please see [changelog_updates.md](docs/dev/changelog_updates.md).
 
 #### Patch Changes
 - Logginghouse-Client: Update logging-house-client extension to v1.1.0
+- EDC Backend
+    - Fixed unrestricted policy wrongly displaying error
 
 ### Deployment Migration Notes
 #### logging-house-client extension

diff --git a/...rs/src/main/java/de/sovity/edc/ext/wrapper/api/common/mappers/policy/PolicyValidator.java b/...rs/src/main/java/de/sovity/edc/ext/wrapper/api/common/mappers/policy/PolicyValidator.java
@@ -76,10 +76,6 @@ public void validateOtherPermissionFieldsUnset(Permission permission, MappingErr
             return;
         }
 
-        if (CollectionUtils.isEmpty(permission.getConstraints())) {
-            errors.add("Permission has no constraints.");
-        }
-
         if (CollectionUtils.isNotEmpty(permission.getDuties())) {
             errors.add("Permission has duties, which is currently unsupported.");
         }

diff --git a/...rc/test/java/de/sovity/edc/ext/wrapper/api/common/mappers/policy/PolicyValidatorTest.java b/...rc/test/java/de/sovity/edc/ext/wrapper/api/common/mappers/policy/PolicyValidatorTest.java
@@ -174,7 +174,6 @@ void testPermission_full() {
 
         // assert
         assertThat(errors.getErrors()).containsExactlyInAnyOrder(
-                "$: Permission has no constraints.",
                 "$: Permission has duties, which is currently unsupported.",
                 "$: Permission has an assigner, which is currently unsupported.",
                 "$: Permission has an assignee, which is currently unsupported.",