chore: self-review

sovity · Nov 29, 2023 · 6f57a3c · 6f57a3c
1 parent 36b3a0f
commit 6f57a3c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/.github/ISSUE_TEMPLATE/release.md b/.github/ISSUE_TEMPLATE/release.md
@@ -53,6 +53,7 @@ Feel free to edit this release checklist in-progress depending on what tasks nee
     - [ ] Merge the `release-prep` PR.
 - [ ] Wait for the main branch to be green.
 - [ ] Test the release `docker-compose.yaml` with `RELEASE_EDC_IMAGE=ghcr.io/sovity/edc-dev:latest`.
+    - [ ] Ensure with a `docker ps -a` that all containers are healthy, and not `healthy: starting` or `healthy: unhealthy`.
 - [ ] Test the postman collection against that running docker-compose.
 - [ ] Create a release and re-use the changelog section as release description, and the version as title.
 - [ ] Check if the pipeline built the release versions in the Actions-Section (or you won't see it).

diff --git a/docs/deployment-guide/goals/production/README.md b/docs/deployment-guide/goals/production/README.md
@@ -12,7 +12,8 @@ This is a productive deployment guide for self-hosting a functional sovity CE ED
 ### Technical Skills
 
 - Ability to deploy, run and expose containered applications to the internet.
-- Ability to Ingress Routes to merge multiple services under a single domain.
+- Ability to configure ingress routes or a reverse proxy of your choice to merge multiple services under a single
+  domain.
 - Know-how on how to secure an otherwise unprotected application with an auth proxy or other solutions fitting
   your situation.
 

diff --git a/...ava/de/sovity/edc/ext/wrapper/api/ui/pages/dashboard/services/SelfDescriptionService.java b/...ava/de/sovity/edc/ext/wrapper/api/ui/pages/dashboard/services/SelfDescriptionService.java
@@ -60,7 +60,7 @@ public class SelfDescriptionService {
      *
      * @deprecated Use {@link #PARTICIPANT_ID} instead.
      */
-    @Deprecated(forRemoval = true, since = "6.0.0")
+    @Deprecated(forRemoval = true)
     private static final String NAME_KEBAB_CASE = configKey("MY_EDC_NAME_KEBAB_CASE");
 
     public String getParticipantId() {

diff --git a/...java/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferProcessTestUtils.java b/...java/de/sovity/edc/ext/wrapper/api/ui/pages/transferhistory/TransferProcessTestUtils.java
@@ -49,7 +49,7 @@ public static void createProvidingTransferProcesses(ContractNegotiationStore sto
 
         // preparing providing transfer process
         var providerAgreement = createContractAgreement(PROVIDING_CONTRACT_ID, PROVIDING_ASSET_ID);
-        createContractNegotiation(store, COUNTER_PARTY_ADDRESS, COUNTER_PARTY_ID, providerAgreement, ContractNegotiation.Type.PROVIDER);
+        createContractNegotiation(store, COUNTER_PARTY_ADDRESS, providerAgreement, ContractNegotiation.Type.PROVIDER);
         createTransferProcess(PROVIDING_ASSET_ID,
                 PROVIDING_CONTRACT_ID,
                 dataAddress,
@@ -65,7 +65,7 @@ public static void createConsumingTransferProcesses(ContractNegotiationStore sto
 
         // preparing consuming transfer process
         var consumerAgreement = createContractAgreement(CONSUMING_CONTRACT_ID, CONSUMING_ASSET_ID);
-        createContractNegotiation(store, COUNTER_PARTY_ADDRESS, COUNTER_PARTY_ID, consumerAgreement, ContractNegotiation.Type.CONSUMER);
+        createContractNegotiation(store, COUNTER_PARTY_ADDRESS, consumerAgreement, ContractNegotiation.Type.CONSUMER);
         createTransferProcess(CONSUMING_ASSET_ID,
                 CONSUMING_CONTRACT_ID,
                 dataAddress,
@@ -109,13 +109,12 @@ private static ContractAgreement createContractAgreement(
     private static void createContractNegotiation(
             ContractNegotiationStore store,
             String counterPartyAddress,
-            String counterPartyConnectorId,
             ContractAgreement agreement,
             ContractNegotiation.Type type
     ) {
         var negotiation = ContractNegotiation.Builder.newInstance()
                 .id(UUID.randomUUID().toString())
-                .counterPartyId(counterPartyConnectorId)
+                .counterPartyId(COUNTER_PARTY_ID)
                 .counterPartyAddress(counterPartyAddress)
                 .protocol(HttpMessageProtocol.DATASPACE_PROTOCOL_HTTP)
                 .contractAgreement(agreement)