Replace ALWAYS TRUE policy definitions with empty constraint expression #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ununhexium
previously approved these changes
Jul 23, 2024
tests/src/test/java/de/sovity/edc/e2e/AlwaysTrueMigrationNewConsumerTest.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/de/sovity/edc/e2e/AlwaysTrueMigrationNewConsumerTest.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/de/sovity/edc/e2e/AlwaysTrueMigrationNewProviderTest.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/de/sovity/edc/e2e/AlwaysTrueMigrationNewProviderTest.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/de/sovity/edc/e2e/common/AlwaysTruePolicyMigrationCommonTest.java
Outdated
Show resolved
Hide resolved
dhommen
pushed a commit
to truzzt/edc-extensions
that referenced
this pull request
Jul 30, 2024
Co-authored-by: Richard Treier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the always true extension to create a policy definition with empty constraints instead of the artificial
ALWAYS_TRUEconstraint.Included are also database migrations to change all existing always-true policies to the new format. Existing contract agreements are not affected.
Checklist