Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync ap migrations #1021

Merged
merged 3 commits into from
Aug 8, 2024
Merged

chore: sync ap migrations #1021

merged 3 commits into from
Aug 8, 2024

Conversation

kamilczaja
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ununhexium ununhexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems missing or extra with this columns renaming.
Is it used externally? Not in this code base?

@kamilczaja
Copy link
Collaborator Author

Copied to have this documented:

so to clear out your doubts

most of the stuff in the crawler migration is not used in the crawler

but it still needs to be there because the database schema needs to look exactly as in the authority portal. remember, the crawler talks directly to the AP database

Copy link
Collaborator

@ununhexium ununhexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kamilczaja kamilczaja merged commit da4b99d into main Aug 8, 2024
16 checks passed
@kamilczaja kamilczaja deleted the sync-ap-migrations branch August 8, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants