Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom Json and JsonLd fields #820

Merged
merged 13 commits into from
Mar 5, 2024

Conversation

ununhexium
Copy link
Collaborator

@ununhexium ununhexium commented Feb 22, 2024

issue 679

  • Add custom JSON property for the asset.
  • Add custom JSON LD property for the asset.
  • Add views (maps of string to string) for the JSON string properties

Checklist

@ununhexium ununhexium linked an issue Feb 22, 2024 that may be closed by this pull request
13 tasks
@ununhexium ununhexium force-pushed the 679-custom-asset-json-ld-is-a-trap-right-now branch from 5d521ca to bfdaecf Compare February 22, 2024 13:44
@ununhexium ununhexium force-pushed the 679-custom-asset-json-ld-is-a-trap-right-now branch from be75714 to 266efee Compare February 22, 2024 14:19
@ununhexium ununhexium marked this pull request as draft February 22, 2024 15:16
@ununhexium ununhexium changed the title [WiP] Avoid JSON LD pitfalls Avoid JSON LD pitfalls Feb 22, 2024
@ununhexium ununhexium marked this pull request as ready for review February 26, 2024 09:33
@kulgg kulgg changed the title Avoid JSON LD pitfalls feat: add custom Json and JsonLd fields Feb 26, 2024
Copy link
Collaborator Author

@ununhexium ununhexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs improvements

kulgg
kulgg previously approved these changes Feb 27, 2024
Copy link
Collaborator

@kulgg kulgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
UPDATES.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@kulgg kulgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulgg kulgg enabled auto-merge (squash) March 5, 2024 11:04
@kulgg kulgg merged commit 93d47f6 into main Mar 5, 2024
18 checks passed
@kulgg kulgg deleted the 679-custom-asset-json-ld-is-a-trap-right-now branch March 5, 2024 11:08
dhommen pushed a commit to truzzt/edc-extensions that referenced this pull request Mar 25, 2024
dhommen pushed a commit to truzzt/edc-extensions that referenced this pull request Mar 26, 2024
dhommen pushed a commit to truzzt/edc-extensions that referenced this pull request Mar 27, 2024
dhommen pushed a commit to truzzt/edc-extensions that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Asset JSON-LD is a trap right now
2 participants