-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add C2C custom messages #970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmberthold
previously requested changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License header are missing :)
/*
* Copyright (c) 2024 sovity GmbH
*
* This program and the accompanying materials are made available under the
* terms of the Apache License, Version 2.0 which is available at
* https://www.apache.org/licenses/LICENSE-2.0
*
* SPDX-License-Identifier: Apache-2.0
*
* Contributors:
* sovity GmbH - initial API and implementation
*
*/
ununhexium
commented
Jun 14, 2024
...demo/src/test/java/de/sovity/edc/extension/sovitymessenger/demo/SovityMessengerDemoTest.java
Outdated
Show resolved
Hide resolved
...ger-demo/src/main/java/de/sovity/edc/extension/sovitymessenger/demo/SovityMessengerDemo.java
Outdated
Show resolved
Hide resolved
...demo/src/test/java/de/sovity/edc/extension/sovitymessenger/demo/SovityMessengerDemoTest.java
Outdated
Show resolved
Hide resolved
...ons/sovity-messenger/src/test/java/de/sovity/edc/extension/messenger/dto/Multiplication.java
Outdated
Show resolved
Hide resolved
...ger/src/test/java/de/sovity/edc/extension/messenger/impl/MessageHandlerRegistryImplTest.java
Outdated
Show resolved
Hide resolved
...-messenger/src/test/java/de/sovity/edc/extension/messenger/impl/SovityMessengerImplTest.java
Outdated
Show resolved
Hide resolved
...emote/src/main/java/de/sovity/edc/extension/e2e/connector/config/ConnectorConfigFactory.java
Outdated
Show resolved
Hide resolved
...emote/src/main/java/de/sovity/edc/extension/e2e/connector/config/ConnectorConfigFactory.java
Show resolved
Hide resolved
...senger-demo/src/main/resources/META-INF/services/org.eclipse.edc.spi.system.ServiceExtension
Outdated
Show resolved
Hide resolved
...essenger-demo/src/main/java/de/sovity/edc/extension/sovitymessenger/demo/message/Common.java
Outdated
Show resolved
Hide resolved
...ty-messenger/src/main/java/de/sovity/edc/extension/messenger/api/MessageHandlerRegistry.java
Outdated
Show resolved
Hide resolved
...s/sovity-messenger/src/main/java/de/sovity/edc/extension/messenger/api/SovityMessageApi.java
Outdated
Show resolved
Hide resolved
extensions/sovity-messenger/src/main/java/de/sovity/edc/extension/messenger/package-info.java
Outdated
Show resolved
Hide resolved
...ty-messenger/src/main/java/de/sovity/edc/extension/messenger/impl/SovityMessengerStatus.java
Outdated
Show resolved
Hide resolved
...ty-messenger/src/main/java/de/sovity/edc/extension/messenger/api/MessageHandlerRegistry.java
Outdated
Show resolved
Hide resolved
richardtreier
requested changes
Jun 17, 2024
...ty-messenger/src/main/java/de/sovity/edc/extension/messenger/api/MessageHandlerRegistry.java
Outdated
Show resolved
Hide resolved
...vity-messenger/src/main/java/de/sovity/edc/extension/messenger/SovityMessengerExtension.java
Outdated
Show resolved
Hide resolved
...ty-messenger/src/main/java/de/sovity/edc/extension/messenger/api/MessageHandlerRegistry.java
Outdated
Show resolved
Hide resolved
...messenger/src/test/java/de/sovity/edc/extension/messenger/echo/SovityMessageRequestTest.java
Show resolved
Hide resolved
...ovity-messenger/src/test/java/de/sovity/edc/extension/messenger/impl/MessageEmitterTest.java
Outdated
Show resolved
Hide resolved
...ger/src/test/java/de/sovity/edc/extension/messenger/impl/MessageHandlerRegistryImplTest.java
Outdated
Show resolved
Hide resolved
...emote/src/main/java/de/sovity/edc/extension/e2e/connector/config/ConnectorConfigFactory.java
Show resolved
Hide resolved
ununhexium
force-pushed
the
1108-custom-c2c-messages
branch
from
June 17, 2024 12:25
43bd486
to
d1b034d
Compare
richardtreier
requested changes
Jun 19, 2024
...-demo/src/main/java/de/sovity/edc/extension/sovitymessenger/demo/message/Multiplication.java
Outdated
Show resolved
Hide resolved
...nsions/sovity-messenger/src/main/java/de/sovity/edc/extension/messenger/SovityMessenger.java
Outdated
Show resolved
Hide resolved
ununhexium
force-pushed
the
1108-custom-c2c-messages
branch
from
June 20, 2024 07:17
7799efe
to
327caee
Compare
richardtreier
requested changes
Jun 24, 2024
...ovity-messenger/src/main/java/de/sovity/edc/extension/messenger/SovityMessengerRegistry.java
Show resolved
Hide resolved
...-messenger/src/test/java/de/sovity/edc/extension/messenger/demo/SovityMessengerDemoTest.java
Show resolved
Hide resolved
richardtreier
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
richardtreier
dismissed
tmberthold’s stale review
June 25, 2024 06:59
Already reviewed now later. Thank you for your earlier reviews!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sovity/PMO-Software/issues/1108
Checklist