Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add C2C custom messages #970

Merged
merged 42 commits into from
Jun 25, 2024
Merged

feat: Add C2C custom messages #970

merged 42 commits into from
Jun 25, 2024

Conversation

ununhexium
Copy link
Collaborator

@ununhexium ununhexium commented Jun 12, 2024

https://github.com/sovity/PMO-Software/issues/1108

Checklist

@ununhexium ununhexium changed the title 1108 custom c2c messages feat: Add C2C custom messages Jun 12, 2024
Copy link
Contributor

@tmberthold tmberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header are missing :)

/*
 *  Copyright (c) 2024 sovity GmbH
 *
 *  This program and the accompanying materials are made available under the
 *  terms of the Apache License, Version 2.0 which is available at
 *  https://www.apache.org/licenses/LICENSE-2.0
 *
 *  SPDX-License-Identifier: Apache-2.0
 *
 *  Contributors:
 *       sovity GmbH - initial API and implementation
 *
 */

Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardtreier richardtreier enabled auto-merge (squash) June 25, 2024 06:58
@richardtreier richardtreier dismissed tmberthold’s stale review June 25, 2024 06:59

Already reviewed now later. Thank you for your earlier reviews!

@richardtreier richardtreier merged commit f6c8a5a into main Jun 25, 2024
19 checks passed
@richardtreier richardtreier deleted the 1108-custom-c2c-messages branch June 25, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants