-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrating transfer history page to api wrapper #351
feat: migrating transfer history page to api wrapper #351
Conversation
src/app/routes/connector-ui/dashboard-page/dashboard-page/dashboard-page-data.service.ts
Outdated
Show resolved
Hide resolved
...onnector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.html
Outdated
Show resolved
Hide resolved
.../connector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes
…tions_to_api_wrapper' into feat/transfer_history_page_migrations_to_api_wrapper
…s in the transfer-history-page.component
...ment-page/contract-agreement-transfer-dialog/contract-agreement-transfer-dialog.component.ts
Outdated
Show resolved
Hide resolved
src/app/routes/connector-ui/dashboard-page/dashboard-page/dashboard-page-data.service.ts
Outdated
Show resolved
Hide resolved
.../connector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.ts
Outdated
Show resolved
Hide resolved
...onnector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.html
Outdated
Show resolved
Hide resolved
...onnector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.html
Outdated
Show resolved
Hide resolved
...onnector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.html
Outdated
Show resolved
Hide resolved
...onnector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.html
Outdated
Show resolved
Hide resolved
.../connector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.ts
Outdated
Show resolved
Hide resolved
.../connector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.ts
Outdated
Show resolved
Hide resolved
.../connector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.ts
Outdated
Show resolved
Hide resolved
…_wrapper # Conflicts: # src/app/core/services/api/edc-api.service.ts # src/app/routes/connector-ui/dashboard-page/dashboard-page/dashboard-page-data.service.ts
…nsfer_history_page_migrations_to_api_wrapper
…tions_to_api_wrapper' into feat/transfer_history_page_migrations_to_api_wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- On initial load the refresh button should not show
- The refresh button uses raised buttons + icons, which isn't used anywhere else anymore, it should be a flat button.
- Maybe instead of offering a refresh button, we should auto update the list every 5s.
- The pagination should be on the right as in the other pages
- Both Detail Dialogs have broken Layouts
- The direction icons look unbalanced with paddings and positioning
- The status icons look unbalanced wwith paddings and positioning
- Last Update could be the 2nd columns maybe
- Table column sizes could have further adjustments. Columns that we know that won't grow large could be small (e.g. date, icon, status, details)
.../connector-ui/transfer-history-page/transfer-history-page/transfer-history-page.component.ts
Outdated
Show resolved
Hide resolved
…tions_to_api_wrapper' into feat/transfer_history_page_migrations_to_api_wrapper
…r history endpoint (api wrapper)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. TODO:
- Fix MDS Link color
- Add "open_in_new" icon for assets where available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request
Migrating transfer history page to api wrapper
How Has This Been Tested?
Mock backend
PR is blocked by
Checklist