Non-root container image #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistency and compatibility with more container runtimes and builders.
Instead of manually modifying the image to work in a non-root environment, use the official unprivileged NGINX image. To install packages and perform other privileged tasks, temporarily switch to root and subsequently switch back. Additionally, use the native envsubst templating already integrated into the NGINX images instead of recreating it. The reason it was not triggering before is that the entrypoint script in the base image checks if the command is `nginx` or `nginx-debug` and if not just executes the command directly without running any further setup.
sybereal
added
task/refactor
richardtreier
pushed a commit
that referenced
this pull request
Aug 31, 2023
Make image work in a nonroot environment. * Docker: fully-qualified image names Consistency and compatibility with more container runtimes and builders. * Docker: rewrite to use unprivileged NGINX Instead of manually modifying the image to work in a non-root environment, use the official unprivileged NGINX image. To install packages and perform other privileged tasks, temporarily switch to root and subsequently switch back. Additionally, use the native envsubst templating already integrated into the NGINX images instead of recreating it. The reason it was not triggering before is that the entrypoint script in the base image checks if the command is `nginx` or `nginx-debug` and if not just executes the command directly without running any further setup. --------- Co-authored-by: Thomas <[email protected]>
richardtreier
added a commit
that referenced
this pull request
Sep 1, 2023
…nges a port This reverts commit 7f732a1.
richardtreier
added a commit
that referenced
this pull request
Sep 1, 2023
…nges a port This reverts commit 7f732a1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Configure container image to run as a non-root user. Based on, supersedes, and closes #370.
How Has This Been Tested?
Local build and manual test.
Checklist