Merge pull request AY2324S1-CS2103-T16-3#219 from elhy1999/branch-dg

Minor Touch-up to DG and SummaryWindow
sp4ce-cowboy · Nov 13, 2023 · 23727ac · 23727ac
2 parents f93a87d + 44acede
commit 23727ac
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md
@@ -932,6 +932,9 @@ The following sequence diagram shows how the different components of UniCa$h int
 
 <img src="images/unicash/EditTransactionSequenceDiagram.png" width="1200" />
 
+<div class="callout callout-important" markdown="span" style="margin-bottom: 20px;">
+**Note:** The lifeline for `EditTransactionCommandParser` should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram.
+</div>
 
 ##### Details
 
@@ -1213,8 +1216,6 @@ This command will exit UniCa$h.
 
 ### User Interface
 
-#### Summary Statistics
-
 [//]: # (#### etc)
 
 ### Minor Features

diff --git a/docs/diagrams/unicash/EditTransactionSequenceDiagram.puml b/docs/diagrams/unicash/EditTransactionSequenceDiagram.puml
@@ -56,6 +56,7 @@ deactivate EditTransactionCommandParser
 
 UniCashParser --> LogicManager : command
 deactivate UniCashParser
+destroy EditTransactionCommandParser
 
 LogicManager -> EditTransactionCommand : execute(model)
 activate EditTransactionCommand

diff --git a/docs/images/unicash/EditTransactionSequenceDiagram.png b/docs/images/unicash/EditTransactionSequenceDiagram.png
diff --git a/docs/team/elhy1999.md b/docs/team/elhy1999.md
@@ -37,7 +37,8 @@ Given below are my contributions to the project.
 
 
 * **Community**:
-  * PRs reviewed (with non-trivial review comments): [[PR #56](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/56)], [[PR #87](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/87)], [[PR #141](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/141)]
+  * PRs reviewed (with non-trivial review comments): [[PR #56](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/56)], [[PR #87](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/87)], [[PR #141](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/141)], [[PR #214](https://github.com/AY2324S1-CS2103-T16-3/tp/pull/214)]
+  * All PRs reviewed can be found [here](https://github.com/AY2324S1-CS2103-T16-3/tp/pulls?q=is%3Apr+reviewed-by%3Aelhy1999)
   * Non-trivial bugs found in other team's projects: [[Issue #131](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/131)], [[Issue #142](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/142)], [[Issue #149](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/149)], [[Issue #163](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/163)], [[Issue #125](https://github.com/AY2324S1-CS2103T-W09-3/tp/issues/125)]
 
 * **Tools**:

diff --git a/src/main/java/unicash/ui/SummaryWindow.java b/src/main/java/unicash/ui/SummaryWindow.java
@@ -138,6 +138,7 @@ public void setLineGraph(HashMap<YearMonth, Double> expenseSummary) {
      * or EARLIEST_YEAR_MONTH
      */
     private static boolean isValidYearMonth(YearMonth yearMonth) {
+        assert yearMonth != null : "yearMonth cannot be null";
         boolean afterMostRecentYearMonth = yearMonth.compareTo(EARLIEST_YEAR_MONTH) >= 0;
         boolean beforeCurrentYearMonth = yearMonth.compareTo(LATEST_YEAR_MONTH) <= 0;
         return afterMostRecentYearMonth & beforeCurrentYearMonth;