Add missing return calls for positions and angles in SolveIsland (#5327)

space-wizards · Aug 10, 2024 · 672819d · 672819d
1 parent 99e4910
commit 672819d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Robust.Shared/Physics/Systems/SharedPhysicsSystem.Island.cs b/Robust.Shared/Physics/Systems/SharedPhysicsSystem.Island.cs
@@ -5,7 +5,6 @@
 using System.Threading.Tasks;
 using Microsoft.Extensions.ObjectPool;
 using Robust.Shared.GameObjects;
-using Robust.Shared.Maths;
 using Robust.Shared.Physics.Components;
 using Robust.Shared.Physics.Dynamics;
 using Robust.Shared.Physics.Dynamics.Contacts;
@@ -960,6 +959,8 @@ private void SolveIsland(
         }
 
         // Cleanup
+        ArrayPool<Vector2>.Shared.Return(positions);
+        ArrayPool<float>.Shared.Return(angles);
         ArrayPool<ContactVelocityConstraint>.Shared.Return(velocityConstraints);
         ArrayPool<ContactPositionConstraint>.Shared.Return(positionConstraints);
     }
@@ -985,7 +986,7 @@ private void FinalisePositions(int start, int end, int offset, List<PhysicsCompo
 
             var solvedPosition = Vector2.Transform(adjustedPosition, parentInvMatrix);
             solvedPositions[offset + i] = solvedPosition - xform.LocalPosition;
-            solvedAngles[offset + i] = angles[i] - worldRot;
+            solvedAngles[offset + i] = angle - worldRot;
         }
     }