Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new revolver, price change #15696

Closed
wants to merge 3 commits into from
Closed

Conversation

Jackal298
Copy link
Contributor

@Jackal298 Jackal298 commented Apr 23, 2023

New cargo order, Deckard and Mateba revolver prices

About the PR

This project grew out of my previous one, I wanted to be able to order a revolver in cargo, since all the existing revolvers did not fit due to the fact that they were already assigned to someone in the game, I decided to make a new revolver. The Rex revolver is identical in characteristics to the inspector revolver. I also rebalanced the price of Deckard and Mateba's revolver, Deckard costs 7000 credits (now it matches its description), Mateba's price is 2500 credits

If you order a revolver in cargo you will receive:
One revolver Rex
Three speedloaders with live ammunition
one box of normal combat 45. magnum

Media

Rex 1

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: added a new revolver Rex, it can be purchased in cargo
  • tweak: Deckard and Mateb revolver price changed

New cargo order, Deckard and Mateba revolver prices
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Apr 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2023

RSI Diff Bot; head commit 769fee5 merging into a6d8d96
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Revolvers/rex.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 769fee5

@keronshb keronshb added the S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. label Apr 23, 2023
@keronshb
Copy link
Contributor

There is a current freeze on new guns: #8524

Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's currently a freeze on new weapons as we culled a lot of the excess ones and even now we still have a few excess. Revolvers in particular aren't balanced amongst themselves already so a new one is just going to be a reskin. The crate change is good.

Comment on lines 68 to 69
- type: StaticPrice
price: 10000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

I have set the price for the decartes pistol based on its description and rarity, I can lower the price to 7000 credits

@metalgearsloth metalgearsloth added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Apr 29, 2023
@Jackal298
Copy link
Contributor Author

There's currently a freeze on new weapons as we culled a lot of the excess ones and even now we still have a few excess. Revolvers in particular aren't balanced amongst themselves already so a new one is just going to be a reskin. The crate change is good.

I understand you, this PR is doing, I did it with a margin for the future, tomorrow I will do pr to increase damage for .45 magnum and change the smg vector caliber, I wanted to make it possible to buy a revolver in cargo, but due to the fact that the game does not I had a suitable revolver, I decided to make my own, I can try to make the differences between revolvers from each other by altering the delay between shots and shooting modes, in the game the revolvers are very weak and I am trying to improve them so that they can be used

@Jackal298 Jackal298 closed this May 4, 2023
@Jackal298 Jackal298 deleted the rexrevolver branch May 4, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Awaiting Changes Status: Changes are required before another review can happen S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants