Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The security dog - Muhtar. The third try. #26191

Closed
wants to merge 13 commits into from
Closed

The security dog - Muhtar. The third try. #26191

wants to merge 13 commits into from

Conversation

NikaVichy
Copy link

About the PR

The third try. Literally skill issue.

  • Added Muhtar and sprites for him
  • Added Muhtar's spawner to every station except for CentComm and Reach
  • Resprited tanks and masks to fit on Muhtar

Why / Balance

  • Imported from ss13.
  • You'll need 10h of sec. dep. to take a ghostrole.
  • Speed higher then human one: 6 tiles for sprint, 4.5 for walking.
  • Has 30 stamina damage - not much to easilly drop a nukie from dark, just enough to stop a criminal running away. Tho stil waiting for your opinion.
  • Has 5 slash and 5 piercing damage. Was playtested, not much, not op at all. Same as previous.
  • Can't slip on anything. Never seen a dog that slips on puddles or smthng like this.
  • He can drag objects or just move things around with his mouth.
  • 75 damage till crit, 140 till death
  • 50 damage before half slowing down. That's a trained dog, it has to deal with damage.
  • 150 stamina damage till stamcrit. Well, it is tougher than any being, cuz it is still trained.

Technical details

  • none

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Added Muhtar - the security dog! Woof!

NikaVichy and others added 2 commits March 16, 2024 22:59
resprited tanks and masks to fit on sheepdog
added sheepdog to all stations except for centcomm and reach
Copy link

ss14-mapserver-beta bot commented Mar 16, 2024

This PR contains new or changed maps:

Bagel

image

03/17/24 11:28

@github-actions github-actions bot added Changes: Map Changes: Might require knowledge of mapping. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Mar 16, 2024
@NikaVichy
Copy link
Author

finally.

Copy link
Contributor

github-actions bot commented Mar 16, 2024

RSI Diff Bot; head commit e57cdb0 merging into 6de5fbf
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Pets/muhtar.rsi

State Old New Status
muhtar Added
muhtar_dead Added

Edit: diff updated after e57cdb0

@Simyon264
Copy link
Contributor

FYI: There is a freeze on new pets currently. See #8524.

New pets. While fluff is nice we have enough cargo-obtainable fluff animals and department mascots, to add new animals they must have something interesting like new AI behaviors or spawn in proc gen maps.

@NikaVichy
Copy link
Author

NikaVichy commented Mar 16, 2024

FYI: There is a freeze on new pets currently. See #8524.

New pets. While fluff is nice we have enough cargo-obtainable fluff animals and department mascots, to add new animals they must have something interesting like new AI behaviors or spawn in proc gen maps.

Tho animals are freezed, it's a new role for players, moreover, gives more RP. If it's gonna be closed - whatever, gonna add it to my own repo.

@NikaVichy
Copy link
Author

I've wanted to replace with it Shiva, but my friend told me, in ss13 there were both Muhtar and Shiva.

@IlyaElDunaev
Copy link
Contributor

I've played as a security dog, an interesting experience. This diversifies the gameplay.

@lzk228
Copy link
Contributor

lzk228 commented Mar 16, 2024

We dont need more pets, at least new features for pets will be added.

Copy link
Member

@VasilisThePikachu VasilisThePikachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Like a lot of people said. Pets are fully frozen. You are welcome to keep this PR open. However, it will most likely not be merged any time soon. (Current Freezes and PR restrictions #8524)
  2. I recommend dropping the mapping changes and instead using migrations.yml to replace shiva. Or if you wanna keep shiva, drop the map changes and let mappers do it themselves. (a mapping maintainer may correct me here. This may be fine)
  3. Fix tests

@NikaVichy
Copy link
Author

  1. Like a lot of people said. Pets are fully frozen. You are welcome to keep this PR open. However, it will most likely not be merged any time soon. (Current Freezes #8524)
  2. I recommend dropping the mapping changes and instead using migrations.yml to replace shiva. Or if you wanna keep shiva, drop the map changes and let mappers do it themselves. (a mapping maintainer may correct me here. This may be fine)
  3. Fix tests

Yes, thanks, I'll do that.

@NikaVichy
Copy link
Author

Also noticed that I've basically erased some meta. Gonna take some time to fix this.

@NikaVichy NikaVichy marked this pull request as draft March 17, 2024 08:13
@Errant-4
Copy link
Member

You could also put it in a K9 Krate TM that can be ordered through cargo (do we currently have a way to limit cargo orders by time or presence of a mob on the station?)

@Vaaankas
Copy link
Contributor

We dont need more pets, at least new features for pets will be added.

Just remove both useless sec pets for this actually fun one.

@NikaVichy
Copy link
Author

NikaVichy commented Mar 17, 2024

You could also put it in a K9 Krate TM that can be ordered through cargo (do we currently have a way to limit cargo orders by time or presence of a mob on the station?)

I'll fix the tests first, wait for approval and only then i'll do it. Don't really want to waste my time and still get rejected.

@Errant-4
Copy link
Member

You could also put it in a K9 Krate TM that can be ordered through cargo (do we currently have a way to limit cargo orders by time or presence of a mob on the station?)

I'll fix the tests first, wait for approval and only then i'll do it. Don't really want to waste my time and still get rejected.

I meant, as a way to avoid "no more roundstart ghostroles"

@NikaVichy
Copy link
Author

NikaVichy commented Mar 17, 2024

You could also put it in a K9 Krate TM that can be ordered through cargo (do we currently have a way to limit cargo orders by time or presence of a mob on the station?)

I'll fix the tests first, wait for approval and only then i'll do it. Don't really want to waste my time and still get rejected.

I meant, as a way to avoid "no more roundstart ghostroles"

image
Still isn't a way.

@github-actions github-actions bot removed the Changes: Map Changes: Might require knowledge of mapping. label Mar 17, 2024
@NikaVichy NikaVichy marked this pull request as ready for review March 17, 2024 13:16
@NikaVichy
Copy link
Author

Fixed tests and meta. Seems good now.
Well, I've decided not to replace Shiva or McGriff, cuz thief still has objectives on them. Removing Shiva or McGriff to add another content isn't a way either.
Now it's fate in your hands.

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Mar 17, 2024
description: ghost-role-information-muhtar-descriprion
rules: ghost-role-information-muhtar-rules
- type: MeleeWeapon
altDisarm: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why false? Disarming seems pretty in-line for a police dog.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why false? Disarming seems pretty in-line for a police dog.

Playtesters' told me that it was hard to hit anybody with LMB. Moreover it has 30 stamina damage, it wont be that hard to stamcrit anybody.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I actualy dont see a way of any dog disarming anybody without harming them. Is it even possible when human is resisting?

@IProduceWidgets
Copy link
Contributor

IProduceWidgets commented Mar 18, 2024

Just a disclaimer that I don't have merge perms, so those reviews are just like my opinions man.

@IProduceWidgets
Copy link
Contributor

One thing I know which has been weird is four legged sprites can look funny when moving. There is the functionality for movement spritesets which could be neat.

Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add custom sprites for a singular mob, it's not worth the maintenance burden.

@NikaVichy
Copy link
Author

Don't add custom sprites for a singular mob, it's not worth the maintenance burden.

The only reason I did it is incorrect sprite displayment. Both tanks and masks were out of place. Tanks were levitating and masks were on eyes, it looked ridiculous.

@NikaVichy
Copy link
Author

One thing I know which has been weird is four legged sprites can look funny when moving. There is the functionality for movement spritesets which could be neat.

None of the four-legged animals have animation now.

NikaVichy and others added 3 commits March 18, 2024 11:51
removed noslip component, made base running speed 5, base walking speed 2.5
Masks and tanks sprites set to default state in master branch.
Now poor Muhtar will look ridiculous.
@FairlySadPanda
Copy link
Contributor

Also just a random contrib

Think a ghost role that aids sec is a bit risky because by necessity it has to be filled by a ghost, who will have access to round knowledge. Sec doc with validhunting rights + ghostrole = high likellihood for abuse

That said this is a great sprite and a police dog makes much more sense than a police spider

@VasilisThePikachu
Copy link
Member

Also just a random contrib

Think a ghost role that aids sec is a bit risky because by necessity it has to be filled by a ghost, who will have access to round knowledge. Sec doc with validhunting rights + ghostrole = high likellihood for abuse

That said this is a great sprite and a police dog makes much more sense than a police spider

It's not even a valid hunting issue and stuff. Just that I (personally) don't want more round-start ghost roles in general.

@VasilisThePikachu VasilisThePikachu added S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. and removed S: Frozen Status: Affects a game area that's frozen. Check "Current Freezes" in the Issues tab. labels Mar 18, 2024
@Emisse
Copy link
Contributor

Emisse commented May 10, 2024

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

@Emisse Emisse closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.