-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The security dog - Muhtar. The third try. #26191
Conversation
resprited tanks and masks to fit on sheepdog added sheepdog to all stations except for centcomm and reach
finally. |
FYI: There is a freeze on new pets currently. See #8524.
|
Tho animals are freezed, it's a new role for players, moreover, gives more RP. If it's gonna be closed - whatever, gonna add it to my own repo. |
I've wanted to replace with it Shiva, but my friend told me, in ss13 there were both Muhtar and Shiva. |
I've played as a security dog, an interesting experience. This diversifies the gameplay. |
We dont need more pets, at least new features for pets will be added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Like a lot of people said. Pets are fully frozen. You are welcome to keep this PR open. However, it will most likely not be merged any time soon. (Current Freezes and PR restrictions #8524)
- I recommend dropping the mapping changes and instead using migrations.yml to replace shiva. Or if you wanna keep shiva, drop the map changes and let mappers do it themselves. (a mapping maintainer may correct me here. This may be fine)
- Fix tests
Yes, thanks, I'll do that. |
Also noticed that I've basically erased some meta. Gonna take some time to fix this. |
You could also put it in a K9 Krate TM that can be ordered through cargo (do we currently have a way to limit cargo orders by time or presence of a mob on the station?) |
Just remove both useless sec pets for this actually fun one. |
I'll fix the tests first, wait for approval and only then i'll do it. Don't really want to waste my time and still get rejected. |
I meant, as a way to avoid "no more roundstart ghostroles" |
|
Everything is as it should be. Placed Autors back on their places as they were before.
Fixed tests and meta. Seems good now. |
description: ghost-role-information-muhtar-descriprion | ||
rules: ghost-role-information-muhtar-rules | ||
- type: MeleeWeapon | ||
altDisarm: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why false? Disarming seems pretty in-line for a police dog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why false? Disarming seems pretty in-line for a police dog.
Playtesters' told me that it was hard to hit anybody with LMB. Moreover it has 30 stamina damage, it wont be that hard to stamcrit anybody.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I actualy dont see a way of any dog disarming anybody without harming them. Is it even possible when human is resisting?
Just a disclaimer that I don't have merge perms, so those reviews are just like my opinions man. |
One thing I know which has been weird is four legged sprites can look funny when moving. There is the functionality for movement spritesets which could be neat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add custom sprites for a singular mob, it's not worth the maintenance burden.
The only reason I did it is incorrect sprite displayment. Both tanks and masks were out of place. Tanks were levitating and masks were on eyes, it looked ridiculous. |
None of the four-legged animals have animation now. |
Masks and tanks sprites set to default state in master branch. Now poor Muhtar will look ridiculous.
Also just a random contrib Think a ghost role that aids sec is a bit risky because by necessity it has to be filled by a ghost, who will have access to round knowledge. Sec doc with validhunting rights + ghostrole = high likellihood for abuse That said this is a great sprite and a police dog makes much more sense than a police spider |
It's not even a valid hunting issue and stuff. Just that I (personally) don't want more round-start ghost roles in general. |
Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this. |
About the PR
The third try. Literally skill issue.
Why / Balance
Technical details
Media
Breaking changes
Changelog
🆑