Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinpointer can now be reconfigured. any pinpointer can't be emagged #26946

Closed
wants to merge 3 commits into from

Conversation

icekot8
Copy link
Contributor

@icekot8 icekot8 commented Apr 14, 2024

About the PR

removed OnEmagged method for pinpointer
now all pinpointers except ninja (it literally only needs it to find a station) can be reconfigured

Why / Balance

The pinpointer was very rarely what the emag was applied to, also according to #8524 we should abbreviate EMAG INTERACTIONS.
this pinpointer change, in my opinion, would make it more interesting, and the objective of hidden disk theft would become at least somewhat real.

Technical details

Now according to the standard:
UpdateTargetName = true
CanRetarget = true

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • remove: Any pinpointer can't be emagged
  • tweak: Now the regular pinpointer can be reconfigured to a different object

@deltanedas
Copy link
Contributor

emagging pinpointer is essential when you are given code to your own nuke rather than the stations

@Golinth
Copy link
Contributor

Golinth commented Apr 15, 2024

emagging pinpointer is essential when you are given code to your own nuke rather than the stations

thats why the normal pinpointer in the nukie shuttle exists, and as far as I can tell, this still allows that one to be reconfigured to point at the nuke

@icekot8 icekot8 changed the title the station pinpointer can now be reconfigured. any pinpointer can't be emagged pinpointer can now be reconfigured. any pinpointer can't be emagged Apr 16, 2024
@icekot8
Copy link
Contributor Author

icekot8 commented Apr 16, 2024

emagging pinpointer is essential when you are given code to your own nuke rather than the stations

done.

@MACMAN2003
Copy link
Contributor

hopefully there's an option to swap it back to the disk

@TheShuEd
Copy link
Member

TheShuEd commented May 7, 2024

I think nuclear ops pinpointer shouldn't be free to reconfigure to anything either, given that it might break their ability to find the nuclear disk

@icekot8
Copy link
Contributor Author

icekot8 commented May 7, 2024

I think nuclear ops pinpointer shouldn't be free to reconfigure to anything either, given that it might break their ability to find the nuclear disk

actually, I thought so too initially, and the ops shuttle has a regular pinpointer. it was just the delta comment that influenced my decision.

@Emisse
Copy link
Contributor

Emisse commented May 10, 2024

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

@Emisse Emisse closed this May 10, 2024
@icekot8
Copy link
Contributor Author

icekot8 commented Jun 14, 2024

can defrost?

@Emisse Emisse reopened this Jun 14, 2024
@AJCM-git AJCM-git added S: Needs Review Status: Requires additional reviews before being fully accepted and removed Feature Freeze: Closed from May 10 to June 14 labels Jun 17, 2024
Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal pinpointers should not be able to be reconfigured, if nukies need it either spawn it or update it as required.

@metalgearsloth metalgearsloth added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jun 29, 2024
@slarticodefast
Copy link
Member

Are you still working on this?

@slarticodefast
Copy link
Member

If you want to continue working on this, leave a comment and I'll re-open the PR.

@slarticodefast slarticodefast added the S: Derelict Status: Abandoned, but may contain something that can be salvaged. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Awaiting Changes Status: Changes are required before another review can happen S: Derelict Status: Abandoned, but may contain something that can be salvaged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants