Traitor flavor (take 3) uhh... #30198
Draft
+190
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This is something Ive been wanting for a while now, As someone who enjoys acting as a member of the given corp its always a weird moment asking another traitor who they work for. This is a huge RP QOL feature and better fleshes out the Spinward Syndicate corporations and groups. |
|
This also good improvement for MRP servers. LRP is RP too! |
|
Wait for design document review PR 264 |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
wew lad |
|
CL isn't informative enough most likely |
This is draft, most info in design document space-wizards/docs#264 |
2 tasks
SlamBamActionman
added
the
S: Untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
reopen/revive #28983 PR that implements flavor, description, and some other stuff, would follow design docs.
New docs PR 264 .
Old docs PR 241 .
Why / Balance
more text, more lore, more rp.
Technical details
Changed smartly some stuff. TraitorRuleComponent.cs is
ObjectiveIssuersnow work as intermediate part for locales.Added factions to
ObjectivesTextGetInfoEvent. This will be useful if blood brothers ever get added and more lore, and though cuz in ss13 syndies corps are not actually a full-fledged “union”.And please don't look in ObjectivesSystem, the summaries are god awful.
Media
Breaking changes
Antagonists change. Though ONLY role, faction, lore descriptions and changed or added, no "fancy" discounts/coupons, antag refactor or smthin'.
Changelog
🆑