-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geofence the nuke disk so it can't be used to stall the round #30436
base: master
Are you sure you want to change the base?
Conversation
This stops the win condition of nuking the nukies |
maybe, but that condition is kind of a meme, and people stall the round with this constantly. I did make it configurable, so we could dial in a time limit on how long you can take the disk if we wanted to try that. |
Is that condition even implemented officially? I’ve never actually seen it completed because every time it gets tried the round stalls so long the crew are ready to mutiny. |
yes it is implemented |
Maybe it doesn't respawn if on the nukie shuttle specifically? |
I'm not even sure the nukie shuttle can fly to the nukie planet anymore tbh. I could change it to add a dummy component to the shuttle and nukie outpost/map but I think it would feel pretty inconsistent. |
To be clear, I'm open to ideas on how to make taking the disk to nukie planet work, I just don't see how to convey it very well. Maybe something like a special machine on the shuttle / outpost? I'm not sure. |
Won't this also prevent disk from being taken onto evac too? Aside from actually evacuating with the disk, there's another win condition for nukies where the nuke is armed on the evac shuttle. |
What if it doesn't bluespace if it's inserted in a nuke? |
no, I special cased that. |
I gave it an event for other components to cancel the geofencing. I also made the nukedisk component check if its in the nuke and if so cancel it. This does require an engine PR though. |
Updated this based on the engine PR review, and also added a 2s rate limit. |
Requires #5322
Fixes #21616
About the PR
If the nuke disk is off the station this tries to send it back.
Why / Balance
Technical details
Media
Breaking changes
Changelog
🆑