Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geofence the nuke disk so it can't be used to stall the round #30436

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

IProduceWidgets
Copy link
Contributor

@IProduceWidgets IProduceWidgets commented Jul 29, 2024

Requires #5322

Fixes #21616

About the PR

If the nuke disk is off the station this tries to send it back.

Why / Balance

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: The nuclear authentication disk now gets bluespaced back to station if its taken off for too long & is not in the nuke.

@Plykiya
Copy link
Contributor

Plykiya commented Jul 29, 2024

This stops the win condition of nuking the nukies

@IProduceWidgets
Copy link
Contributor Author

IProduceWidgets commented Jul 29, 2024

This stops the win condition of nuking the nukies

maybe, but that condition is kind of a meme, and people stall the round with this constantly.

I did make it configurable, so we could dial in a time limit on how long you can take the disk if we wanted to try that.

@TheDoctor1977
Copy link

Is that condition even implemented officially? I’ve never actually seen it completed because every time it gets tried the round stalls so long the crew are ready to mutiny.

@deltanedas
Copy link
Contributor

yes it is implemented

@LordEclipse
Copy link
Member

This stops the win condition of nuking the nukies

maybe, but that condition is kind of a meme, and people stall the round with this constantly.

I did make it configurable, so we could dial in a time limit on how long you can take the disk if we wanted to try that.

Maybe it doesn't respawn if on the nukie shuttle specifically?

@IProduceWidgets
Copy link
Contributor Author

IProduceWidgets commented Jul 29, 2024

This stops the win condition of nuking the nukies

maybe, but that condition is kind of a meme, and people stall the round with this constantly.
I did make it configurable, so we could dial in a time limit on how long you can take the disk if we wanted to try that.

Maybe it doesn't respawn if on the nukie shuttle specifically?

I'm not even sure the nukie shuttle can fly to the nukie planet anymore tbh.

I could change it to add a dummy component to the shuttle and nukie outpost/map but I think it would feel pretty inconsistent.

@IProduceWidgets
Copy link
Contributor Author

To be clear, I'm open to ideas on how to make taking the disk to nukie planet work, I just don't see how to convey it very well.

Maybe something like a special machine on the shuttle / outpost? I'm not sure.

@Scribbles0
Copy link
Contributor

Won't this also prevent disk from being taken onto evac too? Aside from actually evacuating with the disk, there's another win condition for nukies where the nuke is armed on the evac shuttle.

@ThatOneGoblin25
Copy link
Contributor

To be clear, I'm open to ideas on how to make taking the disk to nukie planet work, I just don't see how to convey it very well.

What if it doesn't bluespace if it's inserted in a nuke?

@IProduceWidgets
Copy link
Contributor Author

Won't this also prevent disk from being taken onto evac too? Aside from actually evacuating with the disk, there's another win condition for nukies where the nuke is armed on the evac shuttle.

no, I special cased that.

@IProduceWidgets
Copy link
Contributor Author

I gave it an event for other components to cancel the geofencing.

I also made the nukedisk component check if its in the nuke and if so cancel it. This does require an engine PR though.

@IProduceWidgets
Copy link
Contributor Author

Updated this based on the engine PR review, and also added a 2s rate limit.

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 18, 2024
@eoineoineoin eoineoineoin added S: Needs Review Status: Requires additional reviews before being fully accepted A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuclear Disk needs to be station bound
10 participants